curcur commented on a change in pull request #18556:
URL: https://github.com/apache/flink/pull/18556#discussion_r795130597



##########
File path: 
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/streaming/util/TestStreamEnvironment.java
##########
@@ -129,6 +129,16 @@ private static void randomizeConfiguration(MiniCluster 
miniCluster, Configuratio
                 boolean enabled =
                         randomize(conf, 
StateChangelogOptions.ENABLE_STATE_CHANGE_LOG, true, false);
                 if (enabled) {
+                    randomize(
+                            conf,
+                            
StateChangelogOptions.PERIODIC_MATERIALIZATION_INTERVAL,
+                            Duration.ofMillis(100),
+                            Duration.ofMillis(500),
+                            Duration.ofSeconds(1),
+                            Duration.ofSeconds(5),
+                            Duration.ofMinutes(10),
+                            Duration.ofSeconds(
+                                    Long.MAX_VALUE / 1000 /* max allowed by 
Duration.toMillis */));

Review comment:
       This is a good idea.
   
   But do we have ITTests that last more than 10 minutes?
   
   If not I think the last two are equivalent saying that materialization is 
not played?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to