zentol commented on a change in pull request #18565:
URL: https://github.com/apache/flink/pull/18565#discussion_r795605984



##########
File path: pom.xml
##########
@@ -723,10 +723,10 @@ under the License.
                                                <groupId>org.slf4j</groupId>
                                                
<artifactId>slf4j-log4j12</artifactId>
                                        </exclusion>
-                                       <!-- Netty is only needed for ZK 
servers, not clients -->
                                        <exclusion>
+                                               <!-- Netty is an optional 
dependency, that we currently do not make use of. -->
                                                <groupId>io.netty</groupId>
-                                               <artifactId>netty</artifactId>
+                                               <artifactId>*</artifactId>

Review comment:
       Because it is outdated and only applies to netty 3, while the current ZK 
versions rely on netty 4.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to