pnowojski opened a new pull request #18575:
URL: https://github.com/apache/flink/pull/18575


   SourceOperator.SourceOperatorAvailabilityHelper is prone to the same type of 
memory leak as FLINK-25728. Every time new CompletableFuture.any is created:
   ```
                   currentCombinedFuture =
                           CompletableFuture.anyOf(forcedStopFuture, 
sourceReaderFuture);
                   return currentCombinedFuture;
   ```
   Such future is never garbage collected, because forcedStopFuture will keep a 
reference to it. This will eventually lead to a memory leak, or force stopping 
might take very long time to complete.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (**yes** / no 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't 
know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to