fapaul commented on a change in pull request #18043:
URL: https://github.com/apache/flink/pull/18043#discussion_r796398929
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/program/StreamContextEnvironment.java
##########
@@ -169,12 +233,53 @@ public static void setAsContext(
mergedConfiguration,
userCodeClassLoader,
enforceSingleJobExecution,
- suppressSysout);
+ suppressSysout,
+ allowConfigurations,
+ errors);
};
initializeContextEnvironment(factory);
}
public static void unsetAsContext() {
resetContextEnvironment();
}
+
+ private List<String> collectNotAllowedConfigurations() {
+ final List<String> errors = new ArrayList<>();
+ if (allowConfigurations) {
+ return errors;
+ }
+ final MapDifference<String, String> diff =
+ Maps.difference(originalConfiguration.toMap(),
configuration.toMap());
+ diff.entriesOnlyOnRight()
Review comment:
Good catch. I also update the other cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
