Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2231#discussion_r73652372
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java
---
@@ -186,7 +190,7 @@ public void runFailOnNoBrokerTest() throws Exception {
stream.print();
see.execute("No broker test");
} catch(RuntimeException re) {
- if(kafkaServer.getVersion().equals("0.9")) {
+
if(kafkaServer.getVersion().equals(getExpectedKafkaVersion())) {
--- End diff --
I think the original intent of this assert here was that 0.8 connector
throws different exception messages than 0.9.
So adding the `getExpectedKafkaVersion()` is a bit confusing with respect
to the test intent.
Perhaps we should remove the new `getExpectedKafkaVersion()` and simply
change this to `kafkaServer.getVersion().equals("0.9") ||
kafkaServer.getVersion().equals("0.10")`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
