RyanSkraba commented on a change in pull request #18304:
URL: https://github.com/apache/flink/pull/18304#discussion_r796767156
##########
File path:
flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/ParquetFileFormatFactory.java
##########
@@ -62,6 +62,21 @@
+ " time and LocalDateTime. Hive
0.x/1.x/2.x use local timezone. But Hive 3.x"
+ " use UTC timezone");
+ public static final ConfigOption<String> TIMESTAMP_TIME_UNIT =
+ key("timestamp.time.unit")
+ .stringType()
+ .defaultValue("millis")
Review comment:
The current default value in Hive is "micros" -- we might want to align
with that.
##########
File path:
flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/ParquetFileFormatFactory.java
##########
@@ -62,6 +62,21 @@
+ " time and LocalDateTime. Hive
0.x/1.x/2.x use local timezone. But Hive 3.x"
+ " use UTC timezone");
+ public static final ConfigOption<String> TIMESTAMP_TIME_UNIT =
Review comment:
These are consistent with the [Hive configuration names] and
descriptions
(https://github.com/apache/hive/blob/8409416d2104c5700893552c9ba8614c3024d1ad/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java#L2272):
`hive.parquet.write.int64.timestamp` and `hive.parquet.timestamp.time.unit`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
