echauchot opened a new pull request #18610:
URL: https://github.com/apache/flink/pull/18610
## What is the purpose of the change
Properly fail the job when `SplitEnumeratorContext.runInCoordinatorThread()`
throws an exception
## Brief change log
Introduce `FailJobExceptionHandler` that calls `context.failJob()`. Call it
when `SplitEnumeratorContext.runInCoordinatorThread()` throws an exception by
changing `CoordinatorExecutorThreadFactory`.
Introduce a new `ThreadPoolExecutor` test utility to gain access to the
underlying thread and use it to wait for the handler to process the exception
before asserting.
## Verifying this change
This change added tests and can be verified as follows:
`SourceCoordinatorContextTest#testExceptionInRunnableFailsTheJob()`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes, fail the job
instead of failing the JobManager when an exception is thrown
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no, bug fix
- If yes, how is the feature documented? failure handling is documented in
`SourceCoordinatorContext#runInCoordinatorThread`
R: @tillrohrmann
Already squashed and split commits because some are related to
`flink-test-utils` module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
