igalshilman commented on a change in pull request #17:
URL:
https://github.com/apache/flink-statefun-playground/pull/17#discussion_r798008958
##########
File path: deployments/k8s/04-statefun/00-module.yaml
##########
@@ -5,11 +5,12 @@ metadata:
name: module-config
data:
module.yaml: |+
- kind: io.statefun.endpoints.v2.http
+ kind: io.statefun.endpoints.v2/http
spec:
functions: example/*
urlPathTemplate:
http://functions.statefun.svc.cluster.local:8000/statefun
transport:
+ type: io.statefun.transports.v1/okhttp
Review comment:
This shouldn't be needed anymore once 3.2.0 was released, but apparently
was the case in 3.1.
If you still have the capacity would you be able to quickly verify that this
works for you without specifying the `type`?
##########
File path: deployments/k8s/04-statefun/00-module.yaml
##########
@@ -5,11 +5,12 @@ metadata:
name: module-config
data:
module.yaml: |+
- kind: io.statefun.endpoints.v2.http
+ kind: io.statefun.endpoints.v2/http
Review comment:
oh, good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
