JingGe commented on a change in pull request #18615:
URL: https://github.com/apache/flink/pull/18615#discussion_r799468344
##########
File path:
flink-core/src/main/java/org/apache/flink/api/connector/sink/GlobalCommitter.java
##########
@@ -32,8 +32,11 @@
*
* @param <CommT> The type of information needed to commit data staged by the
sink
* @param <GlobalCommT> The type of the aggregated committable
+ * @deprecated Please use {@code WithPostCommitTopology} with {@code
+ * StandardSinkTopologies#addGlobalCommitter}.
Review comment:
Since the `GlobalCommitter` became a class of operator in #18476, do we
need a new interface design for the user to use the new e.g.
`GlobalCommitOperator` at the interface level? Using `WithPostCommitTopology`
described here means that the `GlobalCommitOperator` can only be used after a
real `Committer`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]