afedulov commented on a change in pull request #18545:
URL: https://github.com/apache/flink/pull/18545#discussion_r800066871
##########
File path: flink-formats/flink-orc/pom.xml
##########
@@ -55,6 +55,14 @@ under the License.
<optional>true</optional>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
+ <optional>true</optional>
Review comment:
This particular format uses it directly:
https://github.com/apache/flink/blob/c6997c97c575d334679915c328792b8a3067cfb5/flink-formats/flink-orc/src/main/java/org/apache/flink/orc/AbstractOrcFileInputFormat.java#L23
The situation seems to be identical to the file-connector-files dependency
in this format, which is declared as provided and optional:
https://github.com/afedulov/flink/blob/40ca1773d5c19b3c12e802cabf25e510eab342c9/flink-formats/flink-orc/pom.xml#L68
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
