zentol commented on a change in pull request #18622:
URL: https://github.com/apache/flink/pull/18622#discussion_r800600096
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/FlinkRexUtil.scala
##########
@@ -53,7 +53,8 @@ object FlinkRexUtil {
@Experimental
private[flink] val TABLE_OPTIMIZER_CNF_NODES_LIMIT: ConfigOption[Integer] =
key("table.optimizer.cnf-nodes-limit")
- .defaultValue(Integer.valueOf(-1))
+ .intType()
+ .defaultValue(Integer.valueOf(-1))
Review comment:
indentation is different than subsequent lines
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/physical/batch/BatchPhysicalSortMergeJoinRule.scala
##########
@@ -150,6 +150,7 @@ object BatchPhysicalSortMergeJoinRule {
@Experimental
val TABLE_OPTIMIZER_SMJ_REMOVE_SORT_ENABLED: ConfigOption[JBoolean] =
key("table.optimizer.smj.remove-sort-enabled")
+ .booleanType()
Review comment:
indentation is different than subsequent lines
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/metadata/FlinkRelMdRowCount.scala
##########
@@ -449,8 +449,9 @@ object FlinkRelMdRowCount {
@Experimental
val TABLE_OPTIMIZER_ROWS_PER_LOCALAGG: ConfigOption[JLong] =
key("table.optimizer.rows-per-local-agg")
+ .longType()
.defaultValue(JLong.valueOf(1000000L))
- .withDescription("Sets estimated number of records that one local-agg
processes. " +
- "Optimizer will infer whether to use local/global aggregate
according to it.")
+ .withDescription("Sets estimated number of records that one local-agg
processes. "
+ + "Optimizer will infer whether to use local/global aggregate
according to it.")
Review comment:
revert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
