RubieV commented on pull request #15551: URL: https://github.com/apache/flink/pull/15551#issuecomment-1031527897
Hi @twalthr , I noticed that this change contains a flaw in the logic of determining the nullability of the `STDDEV_POP` aggregation. The result of `STDDEV_POP` can be `NULL`, however, currently, the nullability is determined on the logical type, which could be `NOT NULL`. The current implementation defines `outputTypeStrategy` as `LogicalTypeMerging::findAvgAggType`, which correctly determines nullability based on the logical type for the `avg` case, but the strategy should force a nullable type for the `STDDEV_POP` case. Glad to follow up with a PR that adds a new method to the LogicalTypeMerging strategy for this case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
