dmvk commented on a change in pull request #18644:
URL: https://github.com/apache/flink/pull/18644#discussion_r800896203
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
##########
@@ -630,10 +630,24 @@ JobManagerRunner createJobManagerRunner(JobGraph
jobGraph, long initializationTi
@Override
public CompletableFuture<Acknowledge> cancelJob(JobID jobId, Time timeout)
{
- Optional<JobManagerRunner> maybeJob = getJobManagerRunner(jobId);
+ boolean isGloballyTerminated;
+ try {
+ isGloballyTerminated = jobResultStore.hasJobResultEntry(jobId);
Review comment:
Other thought would be, that unlike the previous solution, this
safeguard only works with globally terminal states
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
