gaoyunhaii commented on a change in pull request #18642:
URL: https://github.com/apache/flink/pull/18642#discussion_r801283600
##########
File path:
flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/sink/committer/FileCommitter.java
##########
@@ -48,9 +47,10 @@ public FileCommitter(BucketWriter<?, ?> bucketWriter) {
}
@Override
- public List<FileSinkCommittable> commit(List<FileSinkCommittable>
committables)
- throws IOException {
- for (FileSinkCommittable committable : committables) {
+ public void commit(Collection<CommitRequest<FileSinkCommittable>> requests)
+ throws IOException, InterruptedException {
+ for (CommitRequest<FileSinkCommittable> request : requests) {
Review comment:
I think the key is that we might need to know the result of a single
request. We might first not change the behavior here and open a follow-up issue
for this part if there are still controversy~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
