bgeng777 commented on a change in pull request #18531:
URL: https://github.com/apache/flink/pull/18531#discussion_r801334847
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnApplicationFileUploader.java
##########
@@ -335,7 +335,7 @@ public YarnLocalResourceDescriptor uploadFlinkDist(final
Path localJarPath)
*
* @return list of class paths with the file name
*/
- List<String> registerProvidedLocalResources() {
+ List<String> registerProvidedLocalResources(boolean
shouldUsrLibExistInRemote) {
Review comment:
Yes, I totally agree with the assumption and that it just have the same
semantic with ship files.
But in ship files, we will check if `usrlib` exists in ship files and if so
and `INCLUDE_USER_JAR` is DISABLED, we will throw exception due to our previous
discussion.
The reason for me to adding such code is for this case: users have local
`usrlib` and in the remote dirs specified by `provided.lib.dirs`, there is also
a remote `usrlib`. I want to get rid of such case as it could lead to
overriding files in YARN cache's `usrlib`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
