dmvk commented on a change in pull request #504:
URL: https://github.com/apache/flink-web/pull/504#discussion_r801459828



##########
File path: q/gradle-quickstart.sh
##########
@@ -232,6 +223,13 @@ else
   exit 1
 fi
 
+# create gradle dir with gradle wrapper
+mkdir -p gradle/wrapper
+cat > gradle/wrapper/gradle-wrapper.properties <<EOF
+distributionUrl=https\://services.gradle.org/distributions/gradle-7.3.3-all.zip
+EOF

Review comment:
       IMO it does neither harm or help. Personally I'd simply commit the 
wrapper in the project, all other projects do the same and it doesn't really 
add any overhead.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to