zentol commented on a change in pull request #18661:
URL: https://github.com/apache/flink/pull/18661#discussion_r801530193
##########
File path:
flink-connectors/flink-connector-aws-base/src/test/java/org/apache/flink/connector/aws/testutils/AWSServicesTestUtils.java
##########
@@ -64,30 +61,30 @@
private static final String ACCESS_KEY_ID = "accessKeyId";
private static final String SECRET_ACCESS_KEY = "secretAccessKey";
- public static S3AsyncClient getS3Client(String endpoint) throws
URISyntaxException {
+ public static S3AsyncClient createS3Client(String endpoint,
SdkAsyncHttpClient httpClient) {
return S3AsyncClient.builder()
- .httpClient(getHttpClient(endpoint))
+ .httpClient(httpClient)
.region(Region.AP_SOUTHEAST_1)
- .endpointOverride(new URI(endpoint))
- .credentialsProvider(getDefaultCredentials())
+ .endpointOverride(URI.create(endpoint))
+ .credentialsProvider(createDefaultCredentials())
.build();
}
- public static IamAsyncClient getIamClient(String endpoint) throws
URISyntaxException {
+ public static IamAsyncClient createIamClient(String endpoint,
SdkAsyncHttpClient httpClient) {
return IamAsyncClient.builder()
- .httpClient(getHttpClient(endpoint))
+ .httpClient(httpClient)
.region(Region.AWS_GLOBAL)
- .endpointOverride(new URI(endpoint))
- .credentialsProvider(getDefaultCredentials())
+ .endpointOverride(URI.create(endpoint))
+ .credentialsProvider(createDefaultCredentials())
.build();
}
- public static AwsCredentialsProvider getDefaultCredentials() {
+ public static AwsCredentialsProvider createDefaultCredentials() {
Review comment:
that's a fair point!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
