matriv commented on a change in pull request #18632:
URL: https://github.com/apache/flink/pull/18632#discussion_r801570005
##########
File path:
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/StringToTimestampCastRule.java
##########
@@ -48,12 +51,24 @@ public String generateExpression(
String inputTerm,
LogicalType inputLogicalType,
LogicalType targetLogicalType) {
+ int targetPrecision =
LogicalTypeChecks.getPrecision(targetLogicalType);
if (targetLogicalType.is(LogicalTypeRoot.TIMESTAMP_WITHOUT_TIME_ZONE))
{
- return staticCall(STRING_DATA_TO_TIMESTAMP(), inputTerm);
+ final TimestampKind targetTimestampKind = ((TimestampType)
targetLogicalType).getKind();
+ if (targetTimestampKind == TimestampKind.ROWTIME
Review comment:
I don't think that you can create PROCTIME/ROWTIME using TO_TIMESTAMP
either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
