bgeng777 commented on pull request #18531:
URL: https://github.com/apache/flink/pull/18531#issuecomment-1033366985
Hi @wangyang0918 thanks again for the detailed review. Above comments has
been resolved in latest commit .
For the renaming of config option `yarn.per-job-cluster.include-user-jar`, I
have adopted your advice, added `withDeprecatedKeys` and updated comments in
the code.
But I want to check if I should update markdown docs in this PR as well. It
is not much work though I checked some Flink PRs and it seems docs tend to be
modified in a doc revision PR. Any guidance on which one is recommended is
appreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
