zentol commented on a change in pull request #18670:
URL: https://github.com/apache/flink/pull/18670#discussion_r802507757
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##########
@@ -468,9 +468,13 @@ public void close() {
}
@Override
+ @Deprecated
Review comment:
Should be applied to the implemented interface
(`ClusterDescriptor#deployJobCluster`)
##########
File path: docs/content/docs/deployment/resource-providers/yarn.md
##########
@@ -184,6 +157,31 @@ The YARN session client also has a few "shortcut
arguments" for commonly used se
{{< top >}}
+### Per-Job Mode (deprecated)
Review comment:
Replicate deprecation notice from the overview page
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnDeploymentTarget.java
##########
@@ -30,9 +30,11 @@
/** A class containing all the supported deployment target names for Yarn. */
@Internal
public enum YarnDeploymentTarget {
- PER_JOB("yarn-per-job"),
SESSION("yarn-session"),
- APPLICATION("yarn-application");
+ APPLICATION("yarn-application"),
+
+ @Deprecated
+ PER_JOB("yarn-per-job");
Review comment:
why are you changing the order?
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/deployment/executors/AbstractJobClusterExecutor.java
##########
@@ -67,6 +68,10 @@ public AbstractJobClusterExecutor(@Nonnull final
ClientFactory clusterClientFact
@Nonnull final Configuration configuration,
@Nonnull final ClassLoader userCodeClassloader)
throws Exception {
+
+ LOG.warn(
+ "Job Clusters are deprecated since Flink 1.15. Please use an
Application Cluster/Application Mode instead.");
Review comment:
I think we now have 2 log statements in the client, and none on the
server.
This class is used on the client , and you later call deployJobCluster,
which logs another warning.
To cover the server you need to modify the entrypoint accordingly.
##########
File path: docs/content/docs/concepts/flink-architecture.md
##########
@@ -199,7 +217,7 @@ isolation guarantees.
Formerly, a Flink Session Cluster was also known as a Flink Cluster in
`session mode`.
{{< /hint >}}
-### Flink Job Cluster
+### Flink Job Cluster (deprecated)
Review comment:
Replicate deprecation notice from the overview page
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
