zentol commented on a change in pull request #18684:
URL: https://github.com/apache/flink/pull/18684#discussion_r802533731
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -1176,7 +1176,11 @@ private void allocateSlot(
@Override
public CompletableFuture<Acknowledge> freeSlot(
AllocationID allocationId, Throwable cause, Time timeout) {
- freeSlotInternal(allocationId, cause);
+ // only respond to freeing slots when not shutting down to avoid
freeing slot allocation
+ // information
+ if (isRunning()) {
Review comment:
Should we guard `#freeInactiveSlots` in a similar way?
I'm a bit miffed that we can get messages in the first place when the
RpcEndpoint has stopped, but that would require bigger changes I guess.
Does the JM even need to try to release the slots if the TM disconnects? If
the connection is closed doesn't the TM clean things up in any case right away?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
