zentol commented on a change in pull request #18609:
URL: https://github.com/apache/flink/pull/18609#discussion_r802578833
##########
File path: docs/content/docs/dev/datastream/project-configuration.md
##########
@@ -327,9 +318,8 @@ description = """Flink Quickstart Job"""
ext {
javaVersion = '1.8'
- flinkVersion = '1.13-SNAPSHOT'
- scalaBinaryVersion = '2.11'
- slf4jVersion = '1.7.32'
+ flinkVersion = '1.15-SNAPSHOT'
Review comment:
Use `{{< version >}}` instead.
##########
File path: docs/content/docs/dev/datastream/project-configuration.md
##########
@@ -372,19 +358,18 @@ dependencies {
// Compile-time dependencies that should NOT be part of the
// shadow jar and are provided in the lib folder of Flink
// --------------------------------------------------------------
- compile "org.apache.flink:flink-streaming-java:${flinkVersion}"
- compile "org.apache.flink:flink-clients:${flinkVersion}"
+ implementation "org.apache.flink:flink-java:${flinkVersion}"
+ implementation
"org.apache.flink:flink-streaming-java_${scalaBinaryVersion}:${flinkVersion}"
Review comment:
streaming-java has no scala version
##########
File path: docs/content/docs/dev/datastream/project-configuration.md
##########
@@ -372,19 +358,18 @@ dependencies {
// Compile-time dependencies that should NOT be part of the
// shadow jar and are provided in the lib folder of Flink
// --------------------------------------------------------------
- compile "org.apache.flink:flink-streaming-java:${flinkVersion}"
- compile "org.apache.flink:flink-clients:${flinkVersion}"
+ implementation "org.apache.flink:flink-java:${flinkVersion}"
Review comment:
Why are you using a different set of dependencies than the maven
quickstarts (flink-java instead of flink-clients)? Note that flink-clients is
require to run things in the IDE.
##########
File path: docs/content/docs/dev/datastream/project-configuration.md
##########
@@ -327,9 +318,8 @@ description = """Flink Quickstart Job"""
ext {
javaVersion = '1.8'
- flinkVersion = '1.13-SNAPSHOT'
- scalaBinaryVersion = '2.11'
- slf4jVersion = '1.7.32'
+ flinkVersion = '1.15-SNAPSHOT'
+ scalaBinaryVersion = '2.12'
Review comment:
Use `{{< scala_version >}}` instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
