dmvk commented on a change in pull request #18678:
URL: https://github.com/apache/flink/pull/18678#discussion_r802612409
##########
File path: flink-end-to-end-tests/test-scripts/common_docker.sh
##########
@@ -48,7 +48,7 @@ function build_image() {
local server_pid=$!
echo "Preparing Dockeriles"
- retry_times_with_exponential_backoff 5 git clone
https://github.com/apache/flink-docker.git --branch dev-master --single-branch
+ retry_times_with_exponential_backoff 5 git clone
https://github.com/autophagy/flink-docker.git --branch FLINK-24474
--single-branch
Review comment:
Is this still correct since the
https://github.com/apache/flink-docker/pull/102 is merged?
##########
File path:
flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/container/FlinkContainersBuilder.java
##########
@@ -163,6 +163,8 @@ public FlinkContainers build() {
this.conf.set(
CheckpointingOptions.CHECKPOINTS_DIRECTORY,
CHECKPOINT_PATH.toAbsolutePath().toUri().toString());
+ this.conf.set(RestOptions.ADDRESS, "0.0.0.0");
Review comment:
This is basically an "advertised addressed". Since clients (individual
tests) are using the exposed port [1] instead, we don't really have to set this.
[1]
org.apache.flink.tests.util.flink.container.FlinkContainers#getJobManagerPort
##########
File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh
##########
@@ -215,6 +215,8 @@ function cleanup {
internal_cleanup
kubectl wait --for=delete pod --all=true
stop_kubernetes
+ set_config_key "rest.address" "localhost"
Review comment:
isn't this already by `revert_flink_dir`?
##########
File path:
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java
##########
@@ -273,6 +274,8 @@ public void setupYarnClient() {
}
flinkConfiguration = new
org.apache.flink.configuration.Configuration(globalConfiguration);
+ flinkConfiguration.setString(RestOptions.ADDRESS.key(), "0.0.0.0");
+ flinkConfiguration.setString(RestOptions.BIND_ADDRESS.key(),
"0.0.0.0");
Review comment:
Why do we need this for YARN tests? AFAIK everything is running locally,
so binding on loopback should be enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
