zch93 opened a new pull request #18687: URL: https://github.com/apache/flink/pull/18687
## What is the purpose of the change *There is a log4j2 related [issue](https://issues.apache.org/jira/browse/LOG4J2-3155), specifically with the OnStartupTriggeringPolicy. The main problem here is a discrepancy with the time-precision between the 'log_file_create_time' and the 'jvm_startup_time'. So, as the flakiness happens due to this discrepancy (as it had been remarked in [this ticket](https://issues.apache.org/jira/browse/FLINK-24169])) in the OnStartupTriggeringPolicy, I propose to not use this triggering strategy. Instead of using OnStartupTriggeringPolicy, (and if it is necessary to use any triggering strategy next to the DefaultRolloverStrategy) then we can use TimeBasedTriggeringPolicy, with its default interval parameter (1), which means the rollover would occur every days.* ## Brief change log *In flink-dist log4j config:* - *Deleted OnStartupTriggeringPolicy from src/main/flink-bin/conf/log4j.properties* - *Added TimeBasedTriggeringPolicy to src/main/flink-bin/conf/log4j.properties* - *Deleted OnStartupTriggeringPolicy from src/main/flink-bin/conf/log4j-console.properties* - *Added TimeBasedTriggeringPolicy to src/main/flink-bin/conf/log4j-console.properties* ## Verifying this change This change is a minor change in log4j properties, which will have an affect on the remarked test: `YARNSessionCapacitySchedulerITCase.testDetachedPerJobYarnCluster` *Verifying:* - *Run locally that particular test: mvn test -pl flink-yarn-tests -Dtest=YARNSessionCapacitySchedulerITCase* ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): don't know - Anything that affects deployment or recovery: don't know - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not documented -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
