gaborgsomogyi commented on a change in pull request #18664:
URL: https://github.com/apache/flink/pull/18664#discussion_r802913210
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
##########
@@ -205,6 +212,14 @@ public ResourceManager(
this.ioExecutor = ioExecutor;
this.startedFuture = new CompletableFuture<>();
+
+ checkNotNull(configuration, "Flink configuration must not be null");
+ this.delegationTokenManager =
+
configuration.getBoolean(SecurityOptions.KERBEROS_FETCH_DELEGATION_TOKEN)
+ && HadoopDependency.isHadoopCommonOnClasspath(
+ getClass().getClassLoader())
+ ? Optional.of(new
DelegationTokenManager(configuration))
+ : Optional.empty();
Review comment:
> It doesn't feel right to construct the DTM here, it should be
constructed in the ClusterEntrypoint as the rest of the the services. I know
it's quite tricky to propagate it all the way down to the RM, but it allows
easier testing.
Makes sense. That way RM doesn't need Flink config and we can spare quite
some line changes. Tomorrow going to have a look...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
