dannycranmer commented on a change in pull request #18651:
URL: https://github.com/apache/flink/pull/18651#discussion_r803519894
##########
File path:
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java
##########
@@ -267,18 +267,31 @@ private void registerCallback() {
@Override
public void write(InputT element, Context context) throws IOException,
InterruptedException {
+ while (mailboxExecutor.tryYield()) {}
Review comment:
Thanks for the review and explanation. The current implementation is
unnecessarily applying backpressure (FLINK-25792). I propose we take this
feedback and remove the busy loop by migrating to `yield()` as stated. We will
also review the rest of this code (`flush()` etc) with the above feedback in
mind. We can then get this merged and raise a follow up Jira to re-review next
week with @pnowojski. @dmvk how does that sound?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
