CrynetLogistics commented on a change in pull request #18553:
URL: https://github.com/apache/flink/pull/18553#discussion_r803629071
##########
File path:
flink-connectors/flink-connector-aws-kinesis-firehose/src/test/java/org/apache/flink/connector/firehose/sink/KinesisFirehoseSinkITCase.java
##########
@@ -78,42 +76,36 @@
@Before
public void setup() throws Exception {
System.setProperty(SdkSystemSetting.CBOR_ENABLED.property(), "false");
- httpClient =
AWSServicesTestUtils.createHttpClient(mockFirehoseContainer.getEndpoint());
- s3AsyncClient = createS3Client(mockFirehoseContainer.getEndpoint(),
httpClient);
- firehoseAsyncClient =
getFirehoseClient(mockFirehoseContainer.getEndpoint(), httpClient);
- iamAsyncClient = createIamClient(mockFirehoseContainer.getEndpoint(),
httpClient);
+ s3HttpClient = createHttpClient(mockFirehoseContainer.getEndpoint());
+ firehoseHttpClient =
createHttpClient(mockFirehoseContainer.getEndpoint());
+ iamHttpClient = createHttpClient(mockFirehoseContainer.getEndpoint());
+ s3AsyncClient = createS3Client(mockFirehoseContainer.getEndpoint(),
s3HttpClient);
+ firehoseAsyncClient =
+ getFirehoseClient(mockFirehoseContainer.getEndpoint(),
firehoseHttpClient);
+ iamAsyncClient = createIamClient(mockFirehoseContainer.getEndpoint(),
iamHttpClient);
+ env = StreamExecutionEnvironment.getExecutionEnvironment();
Review comment:
Sharing a single http client between the 3 service clients causes the ci
and local to fail intermittently. Frequency approx. 1 in 6. This is
reproducible. Changing them to use separate ones fixes this issue and I have
ran it over 380 times on my local without failure. The issue relates to
`classloaders` being closed prior to usage of the clients.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
