rkhachatryan commented on a change in pull request #18391:
URL: https://github.com/apache/flink/pull/18391#discussion_r803719499
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/metadata/MetadataV2V3SerializerBase.java
##########
@@ -415,7 +440,7 @@ KeyedStateHandle deserializeKeyedStateHandle(
int baseSize = dis.readInt();
List<KeyedStateHandle> base = new ArrayList<>(baseSize);
for (int i = 0; i < baseSize; i++) {
- base.add(deserializeKeyedStateHandle(dis, context));
+
base.add(Preconditions.checkNotNull(deserializeKeyedStateHandle(dis, context)));
Review comment:
I see. Maybe it's better to skip nulls (i.e. don't add to the
collection)?
I'm not sure whether it is guaranteed that there will be no nulls because
this part comes from the nested backend (especially when switching
changelog.enabled off => on).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
