slinkydeveloper commented on a change in pull request #18667:
URL: https://github.com/apache/flink/pull/18667#discussion_r803719918



##########
File path: 
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/connectors/CollectDynamicSink.java
##########
@@ -93,39 +98,40 @@ public ChangelogMode getChangelogMode(ChangelogMode 
requestedMode) {
 
     @Override
     public SinkRuntimeProvider getSinkRuntimeProvider(Context context) {
-        return (DataStreamSinkProvider)
-                inputStream -> {

Review comment:
       yes :cry: the only way to not break it is to not default implement the 
new method




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to