dannycranmer commented on a change in pull request #18686:
URL: https://github.com/apache/flink/pull/18686#discussion_r803844878
##########
File path:
flink-connectors/flink-connector-aws-kinesis-data-streams/src/test/java/org/apache/flink/connectors/kinesis/testutils/KinesaliteContainer.java
##########
@@ -99,25 +99,41 @@ public Properties getHostProperties() {
}
/** Returns the client to access the container from outside the docker
network. */
- public KinesisAsyncClient getContainerClient() throws URISyntaxException {
- return getClient(getContainerEndpointUrl());
+ public KinesisAsyncClient getContainerClient(SdkAsyncHttpClient httpClient)
Review comment:
If you are worried about backwards compatibility, we do not guarantee
this for test code. Suggesting renaming it to force/suggest external consumers
to upgrade and close the client too, if not already.
##########
File path:
flink-connectors/flink-connector-aws-kinesis-data-streams/src/test/java/org/apache/flink/connectors/kinesis/testutils/KinesaliteContainer.java
##########
@@ -99,25 +99,41 @@ public Properties getHostProperties() {
}
/** Returns the client to access the container from outside the docker
network. */
- public KinesisAsyncClient getContainerClient() throws URISyntaxException {
- return getClient(getContainerEndpointUrl());
+ public KinesisAsyncClient getContainerClient(SdkAsyncHttpClient httpClient)
+ throws URISyntaxException {
+ return getClient(getContainerEndpointUrl(), httpClient);
}
- /** Returns the client to access the host from inside the docker network.
*/
+ /** Returns the client with the default async http client. */
public KinesisAsyncClient getHostClient() throws URISyntaxException {
- return getClient(getHostEndpointUrl());
+ return getHostClient(buildSdkAsyncHttpClient());
Review comment:
@CrynetLogistics deprecated what where? I cannot see this change in this
PR. We do not need to maintain backwards compatibility in our test code. Are
you worried if external code is relying on Flink test-jars?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
