XComp commented on a change in pull request #18692:
URL: https://github.com/apache/flink/pull/18692#discussion_r804199654
##########
File path: flink-core/src/main/java/org/apache/flink/core/fs/FileSystem.java
##########
@@ -588,8 +588,10 @@ public static URI getDefaultFsUri() {
*
* @param f The path we want information from
* @return a FileStatus object
- * @throws FileNotFoundException when the path does not exist; IOException
see specific
- * implementation
+ * @throws FileNotFoundException when the path does not exist. This also
applies to cases where
+ * the {@code FileSystem} implementation is based on an object store
like S3 and the passed
+ * {@code Path} refers to a directory (even if it was created through
{@link #mkdirs(Path)};
Review comment:
You're right. I reverted the JavaDoc changes entirely because I feel
that it adds more confusion than it helps. FLINK-26061 is still valid, though.
##########
File path: flink-core/src/main/java/org/apache/flink/core/fs/FileSystem.java
##########
@@ -684,7 +686,9 @@ public boolean exists(final Path f) throws IOException {
/**
* Make the given file and all non-existent parents into directories. Has
the semantics of Unix
- * 'mkdir -p'. Existence of the directory hierarchy is not an error.
+ * 'mkdir -p'. Existence of the directory hierarchy is not an error.
{@code FileSystem}
+ * implementations being backed by an object store like S3 do not support
directories. No
+ * entities are going to be created in that case.
Review comment:
You're right. I reverted the JavaDoc changes entirely because I feel
that it adds more confusion than it helps. FLINK-26061 is still valid, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
