pltbkd commented on a change in pull request #18680: URL: https://github.com/apache/flink/pull/18680#discussion_r804334220
########## File path: flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/sink/compactor/ConcatFileCompactor.java ########## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.file.sink.compactor; + +import org.apache.flink.core.fs.FSDataInputStream; +import org.apache.flink.core.fs.FileSystem; +import org.apache.flink.core.fs.Path; + +import javax.annotation.Nullable; + +import java.io.IOException; +import java.io.InputStream; +import java.io.OutputStream; +import java.util.List; + +/** + * A {@link OutputStreamBasedFileCompactor} implementation that simply concat the compacting files. + * The fileDelimiter will be added between neighbouring files if provided. + */ +public class ConcatFileCompactor extends OutputStreamBasedFileCompactor { + + private static final int CHUNK_SIZE = 4 * 1024 * 1024; + + private final byte[] fileDelimiter; + + public ConcatFileCompactor() { Review comment: ConcatFileCompactor is created by the users and I'd like to provide a non-parameter constructor for users who want to concat files without a delimiter. Passing a null by the user is more or less confusing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
