[
https://issues.apache.org/jira/browse/FLINK-4368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15415533#comment-15415533
]
ASF GitHub Bot commented on FLINK-4368:
---------------------------------------
GitHub user StephanEwen opened a pull request:
https://github.com/apache/flink/pull/2351
[FLINK-4368] [distributed runtime] Eagerly initialize the RPC endpoint
members
This eagerly initialized the RPC members like
- self gateway
- self reference
- main thread executor
and makes them immutable.
This also adds structural comments to the `RpcProtocol` class.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StephanEwen/incubator-flink eager_initialize
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2351.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2351
----
commit 8fdb25c5bbb8d4133791442d37c57bf7f880a8b9
Author: Stephan Ewen <[email protected]>
Date: 2016-08-10T16:27:21Z
[FLINK-4368] [distributed runtime] Eagerly initialize the RPC endpoint
members
----
> Eagerly initialize RrcProtocol members
> --------------------------------------
>
> Key: FLINK-4368
> URL: https://issues.apache.org/jira/browse/FLINK-4368
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
> Environment: FLIP-6 feature branch
> Reporter: Stephan Ewen
>
> The members of the RPC endpoint (RpcProtocol) are lazily created upon the
> {{start()}} call.
> I suggest to initialize them eagerly as they seem to be integral parts
> without which several functions cannot work properly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
