pnowojski commented on a change in pull request #18702:
URL: https://github.com/apache/flink/pull/18702#discussion_r804471668
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/SourceOperator.java
##########
@@ -529,4 +625,43 @@ public void forceStop() {
forcedStopFuture.complete(null);
}
}
+
+ /**
+ * TODO: this wrapper introduces a small performance regression when used.
Maybe we can avoid
+ * using it somehow?
+ */
+ private class WatermarkTrackingOutput<OUT> implements DataOutput<OUT> {
+ private final DataOutput<OUT> output;
+ private long lastWatermark;
Review comment:
In that case this source would report `0` and I guess would never be
blocked (as long as any actually emitted watermarks are positive). But maybe
indeed it's a bit cleaner to use
`org.apache.flink.streaming.api.watermark.Watermark#UNINITIALIZED` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
