autophagy commented on a change in pull request #18678:
URL: https://github.com/apache/flink/pull/18678#discussion_r804681514
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/decorators/FlinkConfMountDecorator.java
##########
@@ -156,6 +157,8 @@ private Pod decoratePod(Pod pod) {
// Remove some configuration options that should not be taken to
cluster side.
clusterSideConfig.removeConfig(KubernetesConfigOptions.KUBE_CONFIG_FILE);
clusterSideConfig.removeConfig(DeploymentOptionsInternal.CONF_DIR);
+ clusterSideConfig.removeConfig(RestOptions.BIND_ADDRESS);
+ clusterSideConfig.removeConfig(RestOptions.ADDRESS);
Review comment:
Prior to opening this PR, I did just set the `BIND_ADDRESS` and didnt
coordinate the address. It caused several test failures involving connection
failures, as things were attempting to connect to the rest endpoint via the
machines hostname and IP, rather than `localhost` or `127.0.0.1`. Is it
possible that whatever figures out the adress when it is unspecified doesn't
take into account the network interface it should be bound on?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
