ruanhang1993 commented on a change in pull request #18516:
URL: https://github.com/apache/flink/pull/18516#discussion_r805231841
##########
File path:
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/testutils/KafkaSourceExternalContext.java
##########
@@ -58,20 +58,20 @@
public class KafkaSourceExternalContext implements
DataStreamSourceExternalContext<String> {
private static final Logger LOG =
LoggerFactory.getLogger(KafkaSourceExternalContext.class);
- private static final String TOPIC_NAME_PREFIX = "kafka-test-topic-";
- private static final Pattern TOPIC_NAME_PATTERN =
Pattern.compile(TOPIC_NAME_PREFIX + ".*");
- private static final String GROUP_ID_PREFIX =
"kafka-source-external-context-";
+ protected static final String TOPIC_NAME_PREFIX = "kafka-test-topic-";
+ protected static final Pattern TOPIC_NAME_PATTERN =
Pattern.compile(TOPIC_NAME_PREFIX + ".*");
+ protected static final String GROUP_ID_PREFIX =
"kafka-source-external-context-";
private static final int NUM_RECORDS_UPPER_BOUND = 500;
private static final int NUM_RECORDS_LOWER_BOUND = 100;
private final List<URL> connectorJarPaths;
- private final String bootstrapServers;
- private final String topicName;
- private final SplitMappingMode splitMappingMode;
- private final AdminClient adminClient;
+ protected final String bootstrapServers;
+ protected final String topicName;
+ protected final SplitMappingMode splitMappingMode;
+ protected final AdminClient adminClient;
Review comment:
This is invoked in another PR. I will revert this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]