zentol commented on a change in pull request #17297:
URL: https://github.com/apache/flink/pull/17297#discussion_r805633304
##########
File path: docs/content/docs/dev/datastream/operators/joining.md
##########
@@ -277,11 +277,9 @@ orangeStream
.intervalJoin(greenStream.keyBy(elem => /* select key */))
.between(Time.milliseconds(-2), Time.milliseconds(1))
.process(new ProcessJoinFunction[Integer, Integer, String] {
- override def processElement(left: Integer, right: Integer, ctx:
ProcessJoinFunction[Integer, Integer, String]#Context, out: Collector[String]):
Unit = {
- out.collect(left + "," + right);
- }
- });
- });
+ override def processElement(left: Integer, right: Integer, ctx:
ProcessJoinFunction[Integer, Integer, String]#Context, out: Collector[String]):
Unit = out.collect(left + "," + right)
Review comment:
please move it back to a separate line
##########
File path: docs/content/docs/dev/dataset/transformations.md
##########
@@ -1195,8 +1195,8 @@ public class PointWeighter
}
DataSet<Tuple2<String, Double>>
- weightedRatings =
- ratings.join(weights) // [...]
+ weightedRatings =
+ ratings.join(weights); // [...]
Review comment:
```suggestion
ratings.join(weights);
```
##########
File path: docs/content.zh/docs/dev/dataset/transformations.md
##########
@@ -1197,8 +1197,8 @@ public class PointWeighter
}
DataSet<Tuple2<String, Double>>
- weightedRatings =
- ratings.join(weights) // [...]
+ weightedRatings =
+ ratings.join(weights); // [...]
Review comment:
```suggestion
ratings.join(weights);
```
##########
File path: docs/content/docs/dev/datastream/user_defined_functions.md
##########
@@ -129,8 +133,8 @@ you can write
```scala
class MyMapFunction extends RichMapFunction[String, Int] {
- def map(in: String):Int = { in.toInt }
-};
+ def map(in: String): Int = in.toInt
Review comment:
inconsistent use of spaces after `:`
##########
File path: docs/content.zh/docs/dev/datastream/operators/joining.md
##########
@@ -277,11 +277,9 @@ orangeStream
.intervalJoin(greenStream.keyBy(elem => /* select key */))
.between(Time.milliseconds(-2), Time.milliseconds(1))
.process(new ProcessJoinFunction[Integer, Integer, String] {
- override def processElement(left: Integer, right: Integer, ctx:
ProcessJoinFunction[Integer, Integer, String]#Context, out: Collector[String]):
Unit = {
- out.collect(left + "," + right);
- }
- });
- });
+ override def processElement(left: Integer, right: Integer, ctx:
ProcessJoinFunction[Integer, Integer, String]#Context, out: Collector[String]):
Unit = out.collect(left + "," + right)
Review comment:
move collect call to separate line
##########
File path: docs/content.zh/docs/dev/datastream/user_defined_functions.md
##########
@@ -136,8 +140,8 @@ data.map { x => x.toInt }
```scala
class MyMapFunction extends RichMapFunction[String, Int] {
- def map(in: String):Int = { in.toInt }
-};
+ def map(in: String): Int = in.toInt
Review comment:
inconsistent use of spaces after `:`
##########
File path: docs/content.zh/docs/dev/datastream/user_defined_functions.md
##########
@@ -77,16 +77,20 @@ data.reduce((i1,i2) -> i1 + i2);
```java
class MyMapFunction implements MapFunction<String, Integer> {
- public Integer map(String value) { return Integer.parseInt(value); }
-};
+ public Integer map(String value) {
+ return Integer.parseInt(value);
+ }
Review comment:
let's move this back to a single line; also applies to other instances
in this file, the english version, and I think 1 other page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
