dmvk commented on a change in pull request #18733:
URL: https://github.com/apache/flink/pull/18733#discussion_r806060325
##########
File path:
flink-connectors/flink-connector-aws-base/src/main/java/org/apache/flink/connector/aws/util/AWSGeneralUtil.java
##########
@@ -273,7 +274,15 @@ public static SdkAsyncHttpClient createAsyncHttpClient(
public static SdkAsyncHttpClient createAsyncHttpClient(
final AttributeMap config, final NettyNioAsyncHttpClient.Builder
httpClientBuilder) {
+ return createAsyncHttpClient(config, httpClientBuilder,
SdkEventLoopGroup.builder());
Review comment:
I think this should be lowered. This will basically mean that for N
tasks (running in the same process), we'll have `N x 2 x num cpus` threads. It
feels that some fairly low number should do for most use cases and we should
allow overrides from the user.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
