JingGe opened a new pull request #18774:
URL: https://github.com/apache/flink/pull/18774


   ## What is the purpose of the change
   
   Connectors are one of the most user-facing module in Flink. Considering 
future maintenance and API compatibility issue, Flink API annotation should be 
added to every Interface/Class that has public visibility. Since Kafka 
connector is one of the most important Flink connectors, this PR could be used 
as reference implementation in the future, especially after connectors have 
been moved to the external repo. 
   According to the Kafka connector evolution strategy, this PR only focus on 
the implementation based on the new Source/Sink design.
   
   ## Brief change log
   
     - add Flink API annotation to every public interface and class developed 
based on the new Source/Sink design.
   
   
   ## Verifying this change
   
   This change is a trivial work to add Flink API annotation without any test 
coverage. A [follow-up 
ticket](https://issues.apache.org/jira/browse/FLINK-26149) has been created, 
which will kickoff once Kafka connector has been moved to the external repo.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't 
know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to