XComp commented on a change in pull request #18692:
URL: https://github.com/apache/flink/pull/18692#discussion_r804187457
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/FileSystemJobResultStore.java
##########
@@ -155,18 +155,15 @@ public boolean hasCleanJobResultEntryInternal(JobID
jobId) throws IOException {
@Override
public Set<JobResult> getDirtyResultsInternal() throws IOException {
final Set<JobResult> dirtyResults = new HashSet<>();
- final FileStatus fs = fileSystem.getFileStatus(this.basePath);
- if (fs.isDir()) {
- FileStatus[] statuses = fileSystem.listStatus(this.basePath);
Review comment:
The presto test still fails with this change being reverted.
`PrestoS3FileSystem` does not support `getFileStatus` on empty directories.
Removing the `isDir` check fixes that issue. I do another round over the presto
implementation tomorrow to understand why it is. FLINK-26061 covers the
difference between presto and hadoop s3 fs
*updated the comment to make more sense out of it*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
