wenlong88 commented on a change in pull request #18363:
URL: https://github.com/apache/flink/pull/18363#discussion_r807017819
##########
File path:
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/delegation/ParserImpl.java
##########
@@ -76,16 +81,42 @@ public ParserImpl(
this.sqlExprToRexConverterFactory = sqlExprToRexConverterFactory;
}
+ /**
+ * Parses a given statement to {@link Operation}. the statement should be
complete and valid, or
+ * an {@link SqlParserException} would be thrown.
+ *
+ * @param statement input statement.
+ * @return parsed operations.
+ */
+ @Override
+ public List<Operation> parse(String statement) {
+ return parseInternal(statement, false);
+ }
+
+ /**
+ * Parses a given statement interactively to {@link Operation}, used in
sql client. Different
+ * from {@link #parse(String)}, it returns a {@link StagingOperation} when
given an incomplete
Review comment:
hi, I have investigated again. currently we don't need the new function:
when the statement is incomplete, parser throws SqlParserEOFException, and we
can just check the exception in sql client.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
