[ 
https://issues.apache.org/jira/browse/FLINK-26166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492711#comment-17492711
 ] 

Gabor Somogyi commented on FLINK-26166:
---------------------------------------

It would be good to work out of the box. I've found that .eslintrc.js assumes 
lf.
One can set there auto which would solve the problem and no additional magic 
would be needed.
WDYT, worth the one-liner in the code or not?

Actual:
{code:java}
rules: {
        'prettier/prettier': [
          'error',
          {
            parser: 'angular'
          }
        ]
      }
{code}

Modified:
{code:java}
rules: {
        'prettier/prettier': [
          'error',
          {
            parser: 'angular',
            endOfLine: 'auto'
          }
        ]
      }
{code}


> flink-runtime-web fails to compile if newline is cr lf
> ------------------------------------------------------
>
>                 Key: FLINK-26166
>                 URL: https://issues.apache.org/jira/browse/FLINK-26166
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / Web Frontend
>    Affects Versions: 1.16.0
>            Reporter: Gabor Somogyi
>            Priority: Minor
>
> Normally I'm developing on linux based system but sometimes reviewing on 
> Windows based machines. Compile blows up in the following way:
> {code:java}
> [INFO] 
> d:\projects\flink\flink-runtime-web\web-dashboard\src\@types\d3-flame-graph\index.d.ts
> [INFO]    1:3   error  Delete `รข??`  prettier/prettier
> ...
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to