Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2360#discussion_r74563211
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/MainThreadExecutor.java
 ---
    @@ -52,4 +52,13 @@
         * @return Future of the callable result
         */
        <V> Future<V> callAsync(Callable<V> callable, Timeout callTimeout);
    +
    +   /**
    +    * Execute the runnable in the main thread of the underlying RPC 
endpoint, with
    +    * a delay of the given number of milliseconds.
    +    *
    +    * @param runnable Runnable to be executed
    +    * @param delay    The delay after which the runnable will be executed
    +    */
    +   void scheduleRunAsync(Runnable runnable, long delay);
    --- End diff --
    
    That is true. The `TimeUnit` variant would make it a little bit more 
explicit for the user that he has to think about the actual delay (unit-wise). 
On the other hand, milliseconds are also kind of the default time unit used 
also in other places.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to