zhuzhurk commented on a change in pull request #18789:
URL: https://github.com/apache/flink/pull/18789#discussion_r807710408
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/partitioner/ForwardForConsecutiveHashPartitionerTest.java
##########
@@ -36,6 +37,12 @@
@Test
public void testConvertToForwardPartitioner() {
+ testConvertToForwardPartitioner(StreamExchangeMode.BATCH);
+ testConvertToForwardPartitioner(StreamExchangeMode.PIPELINED);
+ testConvertToForwardPartitioner(StreamExchangeMode.UNDEFINED);
+ }
+
+ private void testConvertToForwardPartitioner(StreamExchangeMode
streamExchangeMode) {
Review comment:
the `streamExchangeMode` is not used to create job graph below
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/partitioner/ForwardForConsecutiveHashPartitionerTest.java
##########
@@ -53,6 +60,12 @@ public void testConvertToForwardPartitioner() {
@Test
public void testConvertToHashPartitioner() {
+ testConvertToHashPartitioner(StreamExchangeMode.BATCH);
+ testConvertToHashPartitioner(StreamExchangeMode.PIPELINED);
+ testConvertToHashPartitioner(StreamExchangeMode.UNDEFINED);
+ }
+
+ private void testConvertToHashPartitioner(StreamExchangeMode
streamExchangeMode) {
Review comment:
the `streamExchangeMode` is not used to create job graph below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
