GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/2366
[FLINK-4322] Unify CheckpointCoordinator and SavepointCoordinator
The CheckpointCoordinator now also takes over the role of the
SavepointCoordinator. Savepoints are just like other checkpoints - they only
store the metadata in addition. Restoring from a savepoint means loading it
into the CheckpointStore at startup.
This simplifies the code quite a bit. We get rid of the savepoint
coordinator and related classes and cumbersome restoring logic in the main
code. For the tests, we can replace some integration tests with unit tests.
`PendingSavepoint` instances are finalized to become a
`CompletedCheckpoint` like regular `PendingCheckpoint` instances, but in
addition store the savepoint meta data and complete a Promise for callbacks.
`PendingSavepoints` cannot be subsumed and a `CompletedCheckpoint` from a
savepoint does not delete its associated state when being disposed.
@StephanEwen did most of the work and I added and fixed some tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/uce/flink savepointunify
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2366.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2366
----
commit 9d13d3b9c78b5fe6ec436c476492a82b846338aa
Author: Stephan Ewen <[email protected]>
Date: 2016-08-08T17:18:44Z
[FLINK-4322] [checkpointing] Unify CheckpointCoordinator and
SavepointCoordinator
The CheckpointCoordinator now also takes over the role of the
SavepointCoordinator.
Savepoints are just like other checkpoints - they only store the metadata
in addition.
Restoring from a savepoint means loading it into the CheckpointStore at
startup.
commit bcb6cf0b573314449437bc869febfc68f798b0f4
Author: Ufuk Celebi <[email protected]>
Date: 2016-08-11T17:40:07Z
[FLINK-4322] [checkpointing] Add and fix tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
