twalthr commented on a change in pull request #18611:
URL: https://github.com/apache/flink/pull/18611#discussion_r807788430
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/BaseExpressions.java
##########
@@ -470,10 +471,10 @@ public OutType collect() {
/**
* Returns a new value being cast to {@code toType}. A cast error throws
an exception and fails
- * the job. If you're performing a cast operation that may fail, like
{@link DataTypes#INT()} to
- * {@link DataTypes#STRING()}, you should rather use {@link
#tryCast(DataType)}, in order to
- * handle errors. If {@code table.exec.legacy-cast-behaviour} is enabled,
this function behaves
- * like {@link #tryCast(DataType)}.
+ * the job. When performing a cast operation that may fail, like {@link
DataTypes#INT()} to
+ * {@link DataTypes#STRING()}, one should rather use {@link
#tryCast(DataType)}, in order to
Review comment:
Isn't it the other way around (STRING TO INT)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
