slinkydeveloper commented on a change in pull request #18363:
URL: https://github.com/apache/flink/pull/18363#discussion_r807882702
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/SqlMultiLineParser.java
##########
@@ -31,18 +37,61 @@
*/
public class SqlMultiLineParser extends DefaultParser {
Review comment:
I think we should by default try to hide as much as possible. In this
case, this class is not used outside this package (and doesn't really have any
specific utility outside sql client anyway), so we should make it package
private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
