metaswirl commented on a change in pull request #18689:
URL: https://github.com/apache/flink/pull/18689#discussion_r807896671
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/StateTransitions.java
##########
@@ -72,6 +75,21 @@ void goToExecuting(
ExecutionGraph executionGraph,
ExecutionGraphHandler executionGraphHandler,
OperatorCoordinatorHandler operatorCoordinatorHandler);
+
+ /**
+ * Transitions into the {@link Executing} state.
+ *
+ * @param executionGraph executionGraph to pass to the {@link
Executing} state
+ * @param executionGraphHandler executionGraphHandler to pass to the
{@link Executing} state
+ * @param operatorCoordinatorHandler operatorCoordinatorHandler to
pass to the {@link
+ * Executing} state
+ * @param failureCollection collection of failures that are propagated
+ */
+ void goToExecuting(
Review comment:
We need this method for State classes that do belong to
StateWithExecutionGraph and the other method for all other states. (The
WaitForResources does not have a failureCollection and hence cannot propagate
this list.)
Alternatives:
1. Move the failureCollection Object into the AdaptiveScheduler instead of
propagating and add methods to access it. I didn't do this, because I didn't
want to make the AdaptiveScheduler bigger than it already is and this method
would then also be accessible from outside.
2. Go to each state that transitions to Executing and add an empty List
argument.
I prefer the current solution to the alternatives.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
