dmvk commented on a change in pull request #18689:
URL: https://github.com/apache/flink/pull/18689#discussion_r807914546
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/StateTransitions.java
##########
@@ -72,6 +75,21 @@ void goToExecuting(
ExecutionGraph executionGraph,
ExecutionGraphHandler executionGraphHandler,
OperatorCoordinatorHandler operatorCoordinatorHandler);
+
+ /**
+ * Transitions into the {@link Executing} state.
+ *
+ * @param executionGraph executionGraph to pass to the {@link
Executing} state
+ * @param executionGraphHandler executionGraphHandler to pass to the
{@link Executing} state
+ * @param operatorCoordinatorHandler operatorCoordinatorHandler to
pass to the {@link
+ * Executing} state
+ * @param failureCollection collection of failures that are propagated
+ */
+ void goToExecuting(
Review comment:
I'd prefer the option 2) as it might be tricky to keep the methods
aligned otherwise and may lead to misuse.
It will also allow us to easily wrap "state that needs to be transferred" in
the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
