ruanhang1993 commented on a change in pull request #18496:
URL: https://github.com/apache/flink/pull/18496#discussion_r808051755
##########
File path: flink-test-utils-parent/flink-connector-test-utils/pom.xml
##########
@@ -95,4 +95,30 @@
<scope>compile</scope>
</dependency>
</dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+
<shadedArtifactAttached>true</shadedArtifactAttached>
+
<shadedClassifierName>source</shadedClassifierName>
+ <artifactSet>
+ <includes>
+
<include>**/connector/testframe/source/**</include>
Review comment:
This separate jar is used in the e2e sink tests. It only contains the
new
[FromElementsSource](https://github.com/apache/flink/pull/18496/files#diff-dbcd767752498ef1c894717f126ffd9008a3c5b20fd3f9a3c6ffefda95cc93d2)
which is needed in the sink tests.
The normal jar will contain some other dependencies. I am afraid that it
will cause some conflicts. So I create a separate jar.
As @PatrickRen mentioned, this source could be moved to
`flink-streaming-java` in another PR. Then we could get rid of this usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
